Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compilation workflow #319

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 24, 2022

🦟 Bug fix

Fixes the failure we experienced in conda-forge/gz-msgs-feedstock#3 .

Summary

The cross-compilation workflow originally added in #60 and documented in

# Cross-compilation related options
did not work after in #256 the use of ${GZ_MSGS_GEN_EXECUTABLE} was changed back to directly use $<TARGET_FILE:gz_msgs_gen>.

This PR restores the cross-compilation workflow, and it has been tested successfully in conda-forge/gz-msgs-feedstock#3 .

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 24, 2022
@traversaro traversaro marked this pull request as draft November 24, 2022 21:21
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #319 (d3fc146) into gz-msgs9 (2356549) will not change coverage.
The diff coverage is n/a.

❗ Current head d3fc146 differs from pull request most recent head 55c4b13. Consider uploading reports for the commit 55c4b13 to get more accurate results

@@            Coverage Diff            @@
##           gz-msgs9     #319   +/-   ##
=========================================
  Coverage     95.41%   95.41%           
=========================================
  Files            10       10           
  Lines          1026     1026           
=========================================
  Hits            979      979           
  Misses           47       47           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@traversaro traversaro marked this pull request as ready for review November 24, 2022 21:40
@mjcarroll mjcarroll merged commit f88966e into gazebosim:gz-msgs9 Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants