Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditionally find the python interpreter #356

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Fixes #354

Summary

The python interpreter was only being found with BUILD_TESTING enabled. This makes it an unconditional dependency.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from caguero as a code owner June 27, 2023 13:45
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #356 (97a188e) into main (5935dcb) will increase coverage by 1.46%.
The diff coverage is 97.85%.

❗ Current head 97a188e differs from pull request most recent head 1eb3581. Consider uploading reports for the commit 1eb3581 to get more accurate results

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   95.43%   96.89%   +1.46%     
==========================================
  Files          10       28      +18     
  Lines        1030     1064      +34     
==========================================
+ Hits          983     1031      +48     
+ Misses         47       33      -14     
Impacted Files Coverage Δ
core/generator/Generator.hh 100.00% <ø> (ø)
core/generator/generator_main.cc 100.00% <ø> (ø)
...re/include/gz/msgs/detail/PointCloudPackedUtils.hh 94.80% <ø> (ø)
core/include/gz/msgs/MessageFactory.hh 80.00% <80.00%> (ø)
core/src/DynamicFactory.cc 82.00% <82.00%> (ø)
...re/include/gz/msgs/convert/SphericalCoordinates.hh 86.95% <86.95%> (ø)
core/src/Factory.cc 87.50% <87.50%> (ø)
core/src/MessageFactory.cc 96.87% <96.87%> (ø)
compiled/src/gz.cc 90.90% <100.00%> (ø)
core/generator/Generator.cc 91.93% <100.00%> (ø)
... and 18 more

@mjcarroll mjcarroll merged commit 16de9ef into main Jun 27, 2023
@mjcarroll mjcarroll deleted the mjcarroll/find_python branch June 27, 2023 14:13
mjcarroll added a commit that referenced this pull request Jul 12, 2023
This reverts commit 16de9ef.

Signed-off-by: Michael Carroll <[email protected]>
mjcarroll added a commit that referenced this pull request Jul 12, 2023
* Revert "Use cmake extras path variables (#359)"

This reverts commit 786b42a.

Signed-off-by: Michael Carroll <[email protected]>

* Revert "Unconditionally find the python interpreter (#356)"

This reverts commit 16de9ef.

Signed-off-by: Michael Carroll <[email protected]>

* Revert "Generate messages in downstream builds (#339)"

This reverts commit 0c78b96.

Signed-off-by: Michael Carroll <[email protected]>

---------

Signed-off-by: Michael Carroll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants