Add python message generation #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
cc @Voldivh |
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 10 10
Lines 1030 1030
=======================================
Hits 983 983
Misses 47 47 |
Voldivh
approved these changes
Jul 14, 2023
Voldivh
reviewed
Jul 14, 2023
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
@Voldivh I've added options for where the python modules should be installed and added a test. Could you take another look?
Support for Ruby was being removed in #339, so I went ahead and removed it here as well. |
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Voldivh
requested changes
Jul 17, 2023
Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
added a commit
to gazebo-release/gz-msgs10-release
that referenced
this pull request
Jul 17, 2023
gazebosim/gz-msgs#362 removed ruby file generation and added python generation. This updates the install rules to reflect that. Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
added a commit
to gazebo-release/gz-msgs10-release
that referenced
this pull request
Jul 18, 2023
gazebosim/gz-msgs#362 removed ruby file generation and added python generation. This updates the install rules to reflect that. Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Adds python message generation using the old message generation framework. This is an alternative to #355 which uses the new framework.
Test it
Run
ctest -R basic_TEST.py.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.