Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto message for MaterialColor. #414

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented Jan 14, 2024

🎉 New feature

Summary

The MateriaColor proto message allows for changing the material colors of an entities visual component easily and can even be done from ROS using the gz bridge.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This proto message allows for changing the material colors of
an entities visual.

Signed-off-by: Benjamin Perseghetti <[email protected]>
proto/gz/msgs/material_color.proto Show resolved Hide resolved
proto/gz/msgs/material_color.proto Outdated Show resolved Hide resolved
proto/gz/msgs/material_color.proto Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47eed13) 97.67% compared to head (5c03d8a) 97.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           gz-msgs10     #414   +/-   ##
==========================================
  Coverage      97.67%   97.67%           
==========================================
  Files             27       27           
  Lines           1163     1163           
==========================================
  Hits            1136     1136           
  Misses            27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
@caguero caguero merged commit ce3ccb9 into gazebosim:gz-msgs10 Jan 15, 2024
11 checks passed
@bperseghetti bperseghetti deleted the pr-material_color branch January 17, 2024 01:49
bperseghetti added a commit to rudislabs/gz-msgs that referenced this pull request Mar 27, 2024
* Add proto message for MaterialColor.

This proto message allows for changing the material colors of
an entities visual.

Signed-off-by: Benjamin Perseghetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants