Deprecate LOCAL2 in SphericalCoordinates #451
Conversation
With the introduction of gazebosim/gz-math#616. We will be deprecating `LOCAL2` as a work around in favor or `LOCAL`. As part of this change, its probably a good idea to update `gz-msgs` as well. Signed-off-by: Arjo Chakravarty <[email protected]>
…oordinates enum field. Signed-off-by: Martin Pecka <[email protected]>
|
|
||
| GZ_UTILS_WARN_IGNORE__DEPRECATED_DECLARATION |
There was a problem hiding this comment.
This works great!
I was trying to understand how this prevents warnings in gz-msgs, but still gives warnings in downstream libraries when you try to use the LOCAL2 enum, which is what we want. The warning this prevents is the warning emitted by just including msgs/details/spherical_coordinates.pb.h because that file contains
constexpr SphericalCoordinatesType SphericalCoordinatesType_MAX = LOCAL2;
which is a direct use of the LOCAL2 enum.
when downstream libraries include msgs/spherical_coordinates.pb.h, they won't get a warning from that. But if they use LOCAL2 directly, a warning is emitted.
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
I've added a migration note in 338b2b8. It would be great if, in a follow-up PR, you can modify it to add more detail and replace the PR link I added. In the mean time, I'll merge this to fix CI on gz-transport. |
🦟 Bug fix
This PR extends PR #450 .
Summary
In this PR, I include #450 to fix all remaining build failures.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.