Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /bigobj in MSVC to support protobuf 3.12 library (#56) #57

Merged
merged 1 commit into from
May 18, 2020
Merged

Use /bigobj in MSVC to support protobuf 3.12 library (#56) #57

merged 1 commit into from
May 18, 2020

Conversation

jozefizso
Copy link
Contributor

Fixes #56

@jozefizso jozefizso requested a review from caguero as a code owner May 18, 2020 15:54
@j-rivero j-rivero self-requested a review May 18, 2020 19:39
@j-rivero
Copy link
Contributor

Thanks Josef for the PR! Would you mind following the instructions on the DCO bot https:/ignitionrobotics/ign-msgs/pull/57/checks?check_run_id=685922380 to have the commit signed off?

j-rivero
j-rivero approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find any downsides or tradeoffs of the activation of bigobj.

@chapulina chapulina merged commit 6563e6b into gazebosim:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@caguero caguero Awaiting requested review from caguero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/bigobj required on Windows MSVC with Protobuf 3.12
3 participants
@jozefizso @j-rivero @chapulina