Included autogenerated code to the ign_create_docs function #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
chapulina
added
the
boost the docs
chapulina
suggested changes
Aug 13, 2020
There was a problem hiding this comment.
Works for me!
I just noticed that the is_proto_enum functions ended up having more spotlight than they deserve in the classes.html page. That's because being global functions, they just show up as top-level.
Another thing I noticed, but it's outside the scope of this PR, is that the generated functions don't have doxygen documentation. This is definitely not something we need to handle now.
Signed-off-by: ahcorde <[email protected]>
ahcorde
force-pushed
the
ahcorde/doc/autogenerated_code
branch
from
d592a22
to
d8d1d76
Compare
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 7 7
Lines 797 797
=======================================
Hits 683 683
Misses 114 114 Continue to review full report at Codecov.
|
chapulina
approved these changes
Aug 14, 2020
ahcorde
added a commit
that referenced
this pull request
Aug 18, 2020
Signed-off-by: ahcorde <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Aug 18, 2020
Signed-off-by: ahcorde <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Aug 19, 2020
Signed-off-by: ahcorde <[email protected]>
chapulina
pushed a commit
that referenced
this pull request
Aug 20, 2020
Signed-off-by: ahcorde <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with this issue #12 and it depends on this other PR gazebosim/gz-cmake#108
It makes use of the new argument (
AUTOGENERATED_DOC) to include the auto generated code.Signed-off-by: ahcorde [email protected]