Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern CMake targets when including ignition-math #82

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Use modern CMake targets when including ignition-math #82

merged 1 commit into from
Sep 7, 2020

Conversation

joxoby
Copy link
Contributor

@joxoby joxoby commented Sep 1, 2020

No description provided.

@joxoby joxoby requested a review from caguero as a code owner September 1, 2020 18:05
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Sep 1, 2020
chapulina
chapulina approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

caguero
caguero approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@caguero caguero merged commit e40320d into gazebosim:ign-msgs5 Sep 7, 2020
@chapulina chapulina mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joxoby @caguero @chapulina