Workaround model sync #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teo Koon Peng <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Mar 15, 2022
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
ahcorde
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
isaacsim/usd is much more flexible than ignition/sdf. It allows almost any prim to have transformations, changing the transformation of a prim that matches a non-transformable node in ignition causes errors.
The main downside to this workaround is that it makes an assumption on the scene graph of the usd. This means that it only works for usd generated by the connector, usd from other applications (including isaac sim) will not work. Actually this is already the case as the connector assumes the prims are named according to the sdf, this PR just makes the limitation more apparent.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.