Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fork experience #130

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Improve fork experience #130

merged 1 commit into from
Oct 15, 2020

Conversation

chapulina
Copy link
Contributor

Our GitHub actions haven't been running correctly for forks. This should fix all of them:

CI

Removed the codecov token for the Focal builds because we only need to upload coverage reports once, and this causes failures sometimes.

Labeler

Resolves gazebo-tooling/pr-collection-labeler#4.

Uses the new pull_request_target event.

Tested here: gazebosim/testing#14

Triage

Like above, uses the new pull_request_target event.

Tested here: gazebosim/testing#15

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #130 into ign-physics2 will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics2     #130      +/-   ##
================================================
- Coverage         83.27%   83.27%   -0.01%     
================================================
  Files               106      106              
  Lines              3952     3951       -1     
================================================
- Hits               3291     3290       -1     
  Misses              661      661              
Impacted Files Coverage Δ
dartsim/src/SDFFeatures.cc 67.63% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8870c6c...3f50c5f. Read the comment docs.

@chapulina chapulina merged commit 068425f into ign-physics2 Oct 15, 2020
@chapulina chapulina deleted the chapulina/2/forkX branch October 15, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants