Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 ➡️ 3 #307

Merged
merged 6 commits into from
Nov 11, 2021
Merged

2 ➡️ 3 #307

merged 6 commits into from
Nov 11, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Nov 10, 2021

➡️ Forward port

Port ign-physics2 to ign-physics3

Branch comparison: ign-physics3...ign-physics2

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

peci1 and others added 6 commits October 28, 2021 11:53
Adds support for registering callbacks that modify properties of all contacts generated by the dynamics engine. Example implementation for DART is provided.

Signed-off-by: Martin Pecka <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
* Added DART feature for setting joint limits dynamically.

Signed-off-by: Martin Pecka <[email protected]>

* Make code compatible with older DART release (this commit can be reverted once newer DART is out).

Signed-off-by: Martin Pecka <[email protected]>

* Updated the number of models for test.

Signed-off-by: Martin Pecka <[email protected]>

* Apply suggestions from code review

Signed-off-by: Martin Pecka <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>

* Fixed issues from review.

Signed-off-by: Martin Pecka <[email protected]>

* Accomodate DART 6.9

Signed-off-by: Addisu Z. Taddese <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
The header template provided by ign-cmake is used instead.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey self-assigned this Nov 10, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #307 (344cfef) into ign-physics3 (0a1f08d) will increase coverage by 0.25%.
The diff coverage is 88.18%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics3     #307      +/-   ##
================================================
+ Coverage         74.41%   74.66%   +0.25%     
================================================
  Files               115      117       +2     
  Lines              4799     4906     +107     
================================================
+ Hits               3571     3663      +92     
- Misses             1228     1243      +15     
Impacted Files Coverage Δ
dartsim/src/SimulationFeatures.cc 82.90% <85.00%> (-3.59%) ⬇️
dartsim/src/SimulationFeatures.hh 100.00% <100.00%> (ø)
...clude/ignition/physics/detail/ContactProperties.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a1f08d...344cfef. Read the comment docs.

@azeey azeey merged commit 3a09b48 into ign-physics3 Nov 11, 2021
@azeey azeey deleted the azeey/2_to_3 branch November 11, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants