Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows github action workflow #1080

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix Windows github action workflow #1080

merged 3 commits into from
Oct 11, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 9, 2024

🦟 Bug fix

Fix windows github actions workflow. It started failing recently on gz-rendering9 and main, with the error:

usage: colcon [-h] [--log-base LOG_BASE] [--log-level LOG_LEVEL]
              {build,extension-points,extensions,graph,info,list,metadata,test,test-result,version-check}
              ...
colcon: error: unrecognized arguments: -A x64 -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF

Not sure what has changed but the fixed by putting double quotes around each cmake arg passed to colcon build

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Oct 9, 2024
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 changed the title [DO NOT MERGE] Testing CI Fix Windows github action workflow Oct 10, 2024
@iche033 iche033 mentioned this pull request Oct 10, 2024
9 tasks
@iche033 iche033 merged commit c130dd3 into gz-rendering9 Oct 11, 2024
10 of 11 checks passed
@iche033 iche033 deleted the test_ci branch October 11, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants