Suggestions to #200

[chapulina]

• Change Create to Update to reflect better what the function is used for
• Made ogre1 and ogre2 code very similar - the only difference are the 2s
• Changed the Update function so that the existing mesh is updated even when a new mesh doesn't need to be created (in case we add other properties that make capsuleDirty without altering the mesh's name)
• Got the markers to work with ign-gazebo, opening a PR soon.

[chapulina]

I recommend hiding whitespace changes when reviewing, there aren't as many changes as it seems.

[ahcorde]

thank you for the clean up and fixes 👍

[iche033]

I think the Capsule_TEST failed due to segfault on shutdown

[chapulina]

I think the Capsule_TEST failed due to segfault on shutdown

I fixed the test by removing the call to destroy from the destructor. I don't know if things are being correctly cleaned up though, we may have memory leaks. Something to revisit after the release.

[codecov]

Codecov Report

Merging #276 (7043917) into ahcorde/geom/capsule (32c501e) will decrease coverage by 0.06%.
The diff coverage is 29.03%.

❗ Current head 7043917 differs from pull request most recent head 0cb4dfe. Consider uploading reports for the commit 0cb4dfe to get more accurate results

@@                   Coverage Diff                    @@
##           ahcorde/geom/capsule     #276      +/-   ##
========================================================
- Coverage                 57.60%   57.53%   -0.07%     
========================================================
  Files                       157      159       +2     
  Lines                     15592    15595       +3     
========================================================
- Hits                       8982     8973       -9     
- Misses                     6610     6622      +12     

Impacted Files	Coverage Δ
include/ignition/rendering/Capsule.hh	100.00% <ø> (ø)
include/ignition/rendering/base/BaseCapsule.hh	100.00% <ø> (ø)
...gre/include/ignition/rendering/ogre/OgreCapsule.hh	0.00% <ø> (ø)
ogre/src/OgreCapsule.cc	0.00% <0.00%> (ø)
ogre/src/OgreMarker.cc	0.00% <0.00%> (ø)
...2/include/ignition/rendering/ogre2/Ogre2Capsule.hh	100.00% <ø> (ø)
ogre2/src/Ogre2Marker.cc	46.09% <46.66%> (-6.76%)	⬇️
ogre2/src/Ogre2Capsule.cc	61.01% <53.57%> (+4.76%)	⬆️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh	96.66% <0.00%> (-3.34%)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c501e...0cb4dfe. Read the comment docs.