Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden: use ign-common5, ign-math7 #525

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Bumps in garden: use ign-common5, ign-math7 #525

merged 2 commits into from
Dec 29, 2021

Conversation

chapulina
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 27, 2021
@chapulina
Address upstream deprecations
7ebaf46 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Dec 27, 2021
Merged
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Dec 27, 2021
@chapulina chapulina mentioned this pull request Dec 29, 2021
Merged
@scpeters scpeters changed the title Bumps in garden : ci_matching_branch/bump_garden_ign-rendering7 Bumps in garden: use ign-common5, ign-math7 Dec 29, 2021
scpeters
scpeters reviewed Dec 29, 2021
View reviewed changes
tutorials/23_depth_camera_tutorial.md
@@ -63,7 +63,7 @@ depth camera to a memory reserved in a globally scoped `Image`.

\snippet examples/depth_camera/GlutWindow.cc convert depth to image

The other option is the [ConnectNewRgbPointCloud](https:/ignitionrobotics/ign-rendering/blob/ign-rendering6/include/ignition/rendering/DepthCamera.hh#L58) call that receives colored point cloud data on callback.
The other option is the [ConnectNewRgbPointCloud](https:/ignitionrobotics/ign-rendering/blob/ign-rendering7/include/ignition/rendering/DepthCamera.hh#L58) call that receives colored point cloud data on callback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link does not exist yet. I forget what is the preferred approach for branch names in tutorial code links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a mix right now. It's not too bad to have broken links on main because the tutorials aren't published anywhere yet. I don't have a strong preference, but it would be nice to be consistent across all libraries

@codecov
Copy link

codecov bot commented Dec 29, 2021 •
edited
Loading

Codecov Report

Merging #525 (7ebaf46) into main (389e217) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   54.05%   54.06%   +0.01%     
==========================================
  Files         203      203              
  Lines       20287    20281       -6     
==========================================
- Hits        10966    10965       -1     
+ Misses       9321     9316       -5
Impacted Files Coverage Δ
include/ignition/rendering/Scene.hh 0.00% <ø> (ø)
include/ignition/rendering/base/BaseScene.hh 0.00% <ø> (ø)
src/TransformController.cc 58.58% <0.00%> (ø)
src/base/BaseScene.cc 73.06% <ø> (+0.51%) ⬆️
include/ignition/rendering/base/BaseJointVisual.hh 81.96% <50.00%> (+0.09%) ⬆️
include/ignition/rendering/base/BaseCamera.hh 64.94% <100.00%> (-0.26%) ⬇️
src/OrbitViewController.cc 75.58% <100.00%> (ø)
src/OrthoViewController.cc 92.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389e217...7ebaf46. Read the comment docs.

@chapulina
Copy link
Contributor Author

CI is all 🟢, and I assume @scpeters has already taken a high-level look at this. We can address the tutorial comment later, it would be good to do a sweep over all libraries and document what to do in the future.

I'll merge this and its infrastructure PRs to unblock downstream PRs, and then trigger a nightly.

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Dec 29, 2021
@chapulina chapulina merged commit b2b7144 into main Dec 29, 2021
@chapulina chapulina deleted the ci_matching_branch/bump_garden_ign-rendering7 branch December 29, 2021 18:09
srmainwaring added a commit to srmainwaring/ardupilot_gazebo-1 that referenced this pull request Jan 19, 2022
@srmainwaring
Sync with upstream bumps in ignition-garden
f5a15bb 
Remove deprecated include:

- gazebosim/gz-rendering#525

Signed-off-by: Rhys Mainwaring <[email protected]>
@srmainwaring srmainwaring mentioned this pull request Jan 19, 2022
Closed
srmainwaring added a commit to srmainwaring/ardupilot_gazebo-1 that referenced this pull request Feb 2, 2022
@srmainwaring
Sync with upstream bumps in ignition-garden
30fd66b 
Remove deprecated include:

- gazebosim/gz-rendering#525

Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/ardupilot_gazebo-1 that referenced this pull request Mar 28, 2022
@srmainwaring
Sync with upstream bumps in ignition-garden
40df291 
Remove deprecated include:

- gazebosim/gz-rendering#525

Signed-off-by: Rhys Mainwaring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @scpeters