Restore format conversion in Ogre2RenderTarget::Copy #564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
No ticket has been associated with this issue
Summary
When ignition moved to Ogre 2.2+;
Ogre2RenderTarget::Copy
lost the ability to convert between src & dst formats. This PR restores it.It also should be faster because we avoid an unnecessary extra copy.
Additionally,
Ogre2Conversions::ogrePixelFormats
had a missing entry which could trigger bugs if the not-so-popularPF_R8G8B8A8
format is usedChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.