Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose GraphicsAPI #565

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Conversation

darksylinc
Copy link
Contributor

🦟 Bug fix

There's no ticket assigned to this issue.

Summary

The current GraphicsAPI is only available at Ogre2RenderEngine level, which is problematic when we want to be aware of it for multiple means.

ign-gui needs this information so it can decide on how to interface the API with Qt.

In some cases initialization may need additional steps if different APIs are used; so this info is needed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Matias N. Goldberg <[email protected]>
Signed-off-by: Matias N. Goldberg <[email protected]>
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #565 (6d8c27b) into main (1baa935) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   53.14%   53.12%   -0.02%     
==========================================
  Files         213      214       +1     
  Lines       21219    21225       +6     
==========================================
  Hits        11276    11276              
- Misses       9943     9949       +6     
Impacted Files Coverage Δ
include/ignition/rendering/RenderEngine.hh 100.00% <ø> (ø)
...nclude/ignition/rendering/base/BaseRenderEngine.hh 0.00% <0.00%> (ø)
...nclude/ignition/rendering/ogre/OgreRenderEngine.hh 100.00% <ø> (ø)
ogre/src/OgreRenderEngine.cc 73.35% <0.00%> (-0.45%) ⬇️
...lude/ignition/rendering/ogre2/Ogre2RenderEngine.hh 100.00% <ø> (ø)
ogre2/src/Ogre2Material.cc 63.14% <0.00%> (-0.23%) ⬇️
ogre2/src/Ogre2RenderEngine.cc 78.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1baa935...6d8c27b. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one minor comment

include/ignition/rendering/RenderEngine.hh Outdated Show resolved Hide resolved
@darksylinc darksylinc changed the title Expose CurrentGraphicsAPI Expose GraphicsAPI Feb 26, 2022
@iche033 iche033 merged commit 5e67f41 into gazebosim:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants