Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround on warnings for Ubuntu Noble #995

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

j-rivero
Copy link
Contributor

  • Add pragma ignores for Woverloaded-virtual
  • Ignore the warning on FindCUDA removal

🦟 Bug fix

Summary

The support for Ubuntu Noble needs a couple of tweaks for new warnings.

  • GCC warnings coming from Noble warnings: API pure virtual overrides/hidden overrides #991. To preserve the ABI in gz-rendering8 I'm adding pragmas to ignore the warnings and keep the ABI as it is currently.
  • CMake is complaining about the use of FindCUDA module, which is being removed. The transition was not trivial to me and the Optix component probably does not worth too much effort at this point so I'm just silencing the warning by now.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@j-rivero j-rivero requested a review from iche033 as a code owner April 25, 2024 16:33
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 25, 2024
CMakeLists.txt Outdated
@@ -171,6 +171,9 @@ set(GZ_RENDERING_ENGINE_INSTALL_DIR
if(NOT MSVC)
#--------------------------------------
# Find CUDA
# Module is being removed in CMake and needs a non trivial
# migration https://cmake.org/cmake/help/latest/policy/CMP0146.html
cmake_policy(SET CMP0146 OLD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake error here on Jammy:

  CMake Error at CMakeLists.txt:176 (cmake_policy):
    Policy "CMP0146" is not known to this version of CMake.

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero requested a review from iche033 April 26, 2024 16:20
@iche033 iche033 merged commit 9f397e1 into gz-rendering8 Apr 26, 2024
7 of 8 checks passed
@iche033 iche033 deleted the jrivero/ignore_warnings_noble branch April 26, 2024 17:24
@j-rivero j-rivero requested a review from iche033 April 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants