Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 to 6 #203

Merged
merged 4 commits into from
Mar 7, 2022
Merged

5 to 6 #203

merged 4 commits into from
Mar 7, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 7, 2022

➡️ Forward port

Port 5 to 6

Branch comparison: https:/ignitionrobotics//compare/6...5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #203 (ce1a66c) into ign-sensors6 (d606f8a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head ce1a66c differs from pull request most recent head d5c1e4f. Consider uploading reports for the commit d5c1e4f to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-sensors6     #203      +/-   ##
================================================
+ Coverage         76.44%   76.52%   +0.08%     
================================================
  Files                29       29              
  Lines              2908     2918      +10     
================================================
+ Hits               2223     2233      +10     
  Misses              685      685              
Impacted Files Coverage Δ
src/AirPressureSensor.cc 85.91% <100.00%> (ø)
src/AltimeterSensor.cc 88.23% <100.00%> (ø)
src/CameraSensor.cc 77.06% <100.00%> (ø)
src/DepthCameraSensor.cc 74.27% <100.00%> (ø)
src/ImuSensor.cc 85.52% <100.00%> (ø)
src/Lidar.cc 72.34% <100.00%> (ø)
src/LogicalCameraSensor.cc 89.85% <100.00%> (ø)
src/MagnetometerSensor.cc 88.37% <100.00%> (ø)
src/RgbdCameraSensor.cc 75.21% <100.00%> (ø)
src/Sensor.cc 89.34% <100.00%> (+0.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d606f8a...d5c1e4f. Read the comment docs.

@mjcarroll
Copy link
Contributor

@osrf-jenkins retest this please

@ahcorde ahcorde enabled auto-merge (squash) March 7, 2022 16:43
@ahcorde ahcorde disabled auto-merge March 7, 2022 16:43
@ahcorde ahcorde enabled auto-merge March 7, 2022 16:43
@ahcorde ahcorde merged commit 6a0b37f into ign-sensors6 Mar 7, 2022
@ahcorde ahcorde deleted the ahcorde/5_to_6_020722 branch March 7, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants