Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🎉 New feature
Summary
Add
HasConnection
function to all sensors. The main motivation is to so that users of sensors can check to see if there are any subscribers / connections to the sensor data. If none, they can avoid doing any unnecessary computation, see gazebosim/gz-sim#1480Each sensor has its own publishers and events so each needs different implementation. Note that I had to change the
GpuLidarSensor
class' event callback implementation slightly so that I can keep track of the event connection count. The changes also make it more consistent with other rendering sensors event callbacks.Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.