Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows warnings #279

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

Clean up Windows warnings

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #279 (a030711) into ahcorde/3/coverage_lidar (c754e21) will increase coverage by 1.55%.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##           ahcorde/3/coverage_lidar     #279      +/-   ##
============================================================
+ Coverage                     77.57%   79.13%   +1.55%     
============================================================
  Files                            23       23              
  Lines                          2377     2377              
============================================================
+ Hits                           1844     1881      +37     
+ Misses                          533      496      -37     
Impacted Files Coverage Δ
src/AirPressureSensor.cc 86.30% <ø> (ø)
src/AltimeterSensor.cc 88.50% <ø> (ø)
src/CameraSensor.cc 75.37% <ø> (ø)
src/DepthCameraSensor.cc 74.48% <ø> (ø)
src/GpuLidarSensor.cc 88.53% <ø> (ø)
src/ImageGaussianNoiseModel.cc 80.00% <ø> (ø)
src/ImuSensor.cc 90.38% <ø> (ø)
src/Lidar.cc 92.63% <ø> (+19.47%) ⬆️
src/LogicalCameraSensor.cc 90.14% <ø> (ø)
src/MagnetometerSensor.cc 88.63% <ø> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll self-assigned this Oct 26, 2022
@mjcarroll mjcarroll marked this pull request as ready for review October 26, 2022 20:20
@mjcarroll mjcarroll mentioned this pull request Oct 26, 2022
9 tasks
@ahcorde ahcorde merged commit cdb36f9 into ahcorde/3/coverage_lidar Oct 26, 2022
@ahcorde ahcorde deleted the mjcarroll/windows_warnings branch October 26, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants