Skip to content

Commit

Permalink
Fix faulty assumption in INTEGRATION_log_system (#1426)
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Carroll <[email protected]>
  • Loading branch information
mjcarroll authored Apr 6, 2022
1 parent 8c690ff commit 360d573
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions test/integration/log_system.cc
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,7 @@ TEST_F(LogSystemTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(LogDefaults))

// Test case 1:
// No path specified on command line. This does not go through
// ign.cc, so ignLogDirectory() is not initialized (empty string). Recording
// should not take place.
// ign.cc, recording should take place in the `.ignition` directory
{
// Load SDF
sdf::Root recordSdfRoot;
Expand All @@ -354,8 +353,12 @@ TEST_F(LogSystemTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(LogDefaults))
recordServer.Run(true, 200, false);
}

// Check ignLogDirectory is empty
EXPECT_TRUE(ignLogDirectory().empty());
// We should expect to see "auto_default.log" and "state.tlog"
EXPECT_FALSE(ignLogDirectory().empty());
EXPECT_TRUE(common::exists(
common::joinPaths(ignLogDirectory(), "auto_default.log")));
EXPECT_TRUE(common::exists(
common::joinPaths(ignLogDirectory(), "state.tlog")));

// Remove artifacts. Recreate new directory
this->RemoveLogsDir();
Expand Down

0 comments on commit 360d573

Please sign in to comment.