Skip to content

Commit

Permalink
check empty plugins, update issue url
Browse files Browse the repository at this point in the history
Signed-off-by: Ian Chen <[email protected]>
  • Loading branch information
iche033 committed Jun 15, 2022
1 parent 0ec7ad1 commit a05f06b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions src/SystemManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,13 @@ void SystemManager::ProcessPendingEntitySystems()
{
Entity entity = req.entity().id();

if (req.plugins().empty())
{
ignerr << "Unable to add plugins to Entity: '" << entity
<< "'. No plugins specified." << std::endl;
continue;
}

for (auto &pluginMsg : req.plugins())
{
std::string fname = pluginMsg.filename();
Expand All @@ -231,5 +238,3 @@ void SystemManager::ProcessPendingEntitySystems()
}
this->systemsToAdd.clear();
}


2 changes: 1 addition & 1 deletion test/integration/entity_system.cc
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class EntitySystemTest : public InternalFixture<::testing::TestWithParam<int>>
};

/////////////////////////////////////////////////
// See https:/ignitionrobotics/ign-gazebo/issues/1175
// See https:/gazebosim/gz-sim/issues/1175
TEST_P(EntitySystemTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(PublishCmd))
{
TestPublishCmd(
Expand Down

0 comments on commit a05f06b

Please sign in to comment.