Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform the APIs to apply forces and wrenches to a link #201

Open
diegoferigo opened this issue Jun 9, 2020 · 2 comments
Open

Uniform the APIs to apply forces and wrenches to a link #201

diegoferigo opened this issue Jun 9, 2020 · 2 comments
Labels
help wanted We accept pull requests!

Comments

@diegoferigo
Copy link
Contributor

The application of link forces and wrenches is performed by the following two methods:

https:/ignitionrobotics/ign-gazebo/blob/d7cd60a7ec8d5931f54d155894b66974dbcf78a2/include/ignition/gazebo/Link.hh#L187-L192

https:/ignitionrobotics/ign-gazebo/blob/d7cd60a7ec8d5931f54d155894b66974dbcf78a2/include/ignition/gazebo/Link.hh#L194-L202

As you can notice, the former applies a force to the CoM of the link, the latter to the link origin. This mismatch could be somehow misleading.

Partially related, it would be also nice having a method to apply a wrench for more than one physics step. In the case of a small physics step size and multiple iterations, a single step could be sometimes limiting. Though, I think that it's not that straightforward and it would require both a new component and some modification to the Physics system.

@chapulina
Copy link
Contributor

This feels like deja vu 😅 gazebosim/gazebo-classic#354

@diegoferigo
Copy link
Contributor Author

Ahaha you have a good memory @chapulina! 😄 The match is impressing, not one but two same requests in a single issue, wow. Not sure if I should feel disturbed by this xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We accept pull requests!
Projects
None yet
Development

No branches or pull requests

2 participants