Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot light does not use <direction> tag. #329

Closed
nkoenig opened this issue Sep 2, 2020 · 4 comments
Closed

Spot light does not use <direction> tag. #329

nkoenig opened this issue Sep 2, 2020 · 4 comments
Labels
good first issue Good for newcomers help wanted We accept pull requests! rendering Involves Ignition Rendering

Comments

@nkoenig
Copy link
Contributor

nkoenig commented Sep 2, 2020

According to SDF, a spot light should use the <direction> tag.

Gazebo doesn't seem to follow this guidance. See here.

Not sure if SDF is wrong, or Gazebo.

@chapulina
Copy link
Contributor

I always thought that the direction tag added extra unnecessary complexity. Lights already have a pose, which should be enough to define where they're looking at.

@nkoenig
Copy link
Contributor Author

nkoenig commented Sep 2, 2020

Yeah, I think that's right. Maybe the SDF description just needs updating. @iche033 , what do you think?

@iche033
Copy link
Contributor

iche033 commented Sep 2, 2020

I remember in gazebo-classic the pose tag applies additional rotation to the direction vector. We can keep the behavior consistent

@chapulina chapulina added rendering Involves Ignition Rendering help wanted We accept pull requests! good first issue Good for newcomers labels Sep 15, 2020
@chapulina
Copy link
Contributor

Done in #718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted We accept pull requests! rendering Involves Ignition Rendering
Projects
None yet
Development

No branches or pull requests

3 participants