Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to GUI config and minimal scene example #1051

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

chapulina
Copy link
Contributor

Bug fix

Summary

  • Fix feature list
  • Remove View Angle from default config
  • Remove anchors from invisible plugins, they should be on the top-left corner of the screen anyway
  • Reorder plugins on the example

Another thing we need to do is to update all examples to use MinimalScene instead of GzScene. That can come in a separate PR.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) beta Targeting beta release of upcoming collection labels Sep 24, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we want all the plugins to be docked_collapsed in minimal_scene.sdf?

@chapulina
Copy link
Contributor Author

do we want all the plugins to be docked_collapsed in minimal_scene.sdf?

When there are more than 2 docked plugins, I like to collapse them so they look a bit more organized. We may add more there in the future too. But that's very subjective, what do you think?

@jennuine
Copy link
Contributor

I agree :)

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #1051 (aa743f6) into main (f4d47b5) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   63.71%   64.01%   +0.30%     
==========================================
  Files         257      255       -2     
  Lines       20064    19916     -148     
==========================================
- Hits        12783    12750      -33     
+ Misses       7281     7166     -115     
Impacted Files Coverage Δ
src/EntityComponentManager.cc 84.95% <0.00%> (-0.15%) ⬇️
src/gui/plugins/view_angle/ViewAngle.cc
src/gui/plugins/view_angle/ViewAngle.hh

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0381d...aa743f6. Read the comment docs.

@chapulina chapulina merged commit b286a57 into main Sep 25, 2021
@chapulina chapulina deleted the chapulina/6/minimal_scene branch September 25, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants