Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new CMake policy to fix protobuf compilation #1059

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

Blast545
Copy link
Contributor

Summary

This PR is actually a back port from main PR #1046, this will fix a build regression caused when using CMake versions older than 3.13.

This fix was merged in main, and this back port targets ign-gazebo3 aiming to be port forwarded up to ign-gazebo5 and address Windows CI build regressions there.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Jorge Perez [email protected]

Note to maintainers: Remember to use Squash-Merge

@Blast545 Blast545 self-assigned this Sep 27, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Sep 27, 2021
@Blast545 Blast545 added bug Something isn't working 🏰 citadel Ignition Citadel and removed 🏰 citadel Ignition Citadel labels Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1059 (bd23527) into ign-gazebo3 (d9195c4) will increase coverage by 0.33%.
The diff coverage is 78.48%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1059      +/-   ##
===============================================
+ Coverage        77.56%   77.90%   +0.33%     
===============================================
  Files              208      221      +13     
  Lines            11385    12687    +1302     
===============================================
+ Hits              8831     9884    +1053     
- Misses            2554     2803     +249     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/ContactSensor.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (ø)
...nclude/ignition/gazebo/components/LogicalCamera.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Sensor.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/Serialization.hh 90.32% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <0.00%> (ø)
.../plugins/component_inspector/ComponentInspector.cc 8.58% <0.00%> (-0.90%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5858ae6...bd23527. Read the comment docs.

@chapulina chapulina merged commit f834987 into ign-gazebo3 Sep 27, 2021
@chapulina chapulina deleted the blast545/citadel_protobux_fix branch September 27, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants