Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure config directory is created #1070

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Fixes gazebosim/gz-gui#294

Summary

Make sure the directories are created before copying the file there.

This is already done for server.config:

https:/ignitionrobotics/ign-gazebo/blob/ad0ddc4d04c8a2d021b86bde182be4bc04a8b71a/src/ServerConfig.cc#L887-L918

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added bug Something isn't working beta Targeting beta release of upcoming collection labels Sep 29, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #1070 (76c6a28) into main (ad0ddc4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage   64.06%   64.06%           
=======================================
  Files         255      255           
  Lines       19963    19963           
=======================================
  Hits        12790    12790           
  Misses       7173     7173           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0ddc4...76c6a28. Read the comment docs.

@ahcorde
Copy link
Contributor

ahcorde commented Sep 29, 2021

@osrf-jenkins retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants