Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix light control standalone example #1077

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 1, 2021

Signed-off-by: Alejandro Hernández [email protected]

🦟 Bug fix

Summary

Fixed light control standalone example

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Alejandro Hernández <[email protected]>
@ahcorde ahcorde self-assigned this Oct 1, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #1077 (b0c6e04) into ign-gazebo4 (4f3dd67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo4    #1077   +/-   ##
============================================
  Coverage        67.23%   67.23%           
============================================
  Files              243      243           
  Lines            18253    18253           
============================================
  Hits             12273    12273           
  Misses            5980     5980           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3dd67...b0c6e04. Read the comment docs.

@ahcorde ahcorde merged commit d000c9a into ign-gazebo4 Oct 4, 2021
@ahcorde ahcorde deleted the ahcorde/fix/light_control_example branch October 4, 2021 07:37
@ahcorde ahcorde added the hacktoberfest-accepted hacktoberfest-accepted label Oct 11, 2021
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants