Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the actor tension parameter #1091

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Use the actor tension parameter #1091

merged 3 commits into from
Oct 20, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 6, 2021

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

Adds support for the trajectory tension parameter. See: gazebosim/gz-common#256.

Test it

Run ign gazebo -v 4 actor.sdf, and try adjusting the tension SDF parameter.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@nkoenig nkoenig mentioned this pull request Oct 6, 2021
Merged
8 tasks
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 6, 2021
mjcarroll
mjcarroll reviewed Oct 6, 2021
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test we can add for this for varying tension parameters? We would expect the actor to hit the waypoint versus miss depending on the tension, correct?

@mjcarroll mjcarroll added the needs upstream release Blocked by a release of an upstream library label Oct 6, 2021
@nkoenig
Copy link
Contributor Author

nkoenig commented Oct 14, 2021

Is there any test we can add for this for varying tension parameters? We would expect the actor to hit the waypoint versus miss depending on the tension, correct?

I put a test in ign-common.

@mjcarroll mjcarroll mentioned this pull request Oct 15, 2021
Merged
5 tasks
@nkoenig
Copy link
Contributor Author

nkoenig commented Oct 15, 2021

@osrf-jenkins run tests please.

bump to ign-common 4.4
4ebbe1b 
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig removed the needs upstream release Blocked by a release of an upstream library label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ign-gazebo6@614340c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c0a39f9 differs from pull request most recent head 4ebbe1b. Consider uploading reports for the commit 4ebbe1b to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             ign-gazebo6    #1091   +/-   ##
==============================================
  Coverage               ?   64.05%           
==============================================
  Files                  ?      255           
  Lines                  ?    20064           
  Branches               ?        0           
==============================================
  Hits                   ?    12852           
  Misses                 ?     7212           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614340c...4ebbe1b. Read the comment docs.

@nkoenig
Copy link
Contributor Author

nkoenig commented Oct 20, 2021

CI seems to be failing for unrelated reasons.

@nkoenig nkoenig merged commit 3a1adb3 into ign-gazebo6 Oct 20, 2021
@nkoenig nkoenig deleted the actor_tension branch October 20, 2021 15:39
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
@nkoenig @WilliamLewww
Use the actor tension parameter (gazebosim#1091)
38e6aa6 
* Use the actor tension parameter

Signed-off-by: Nate Koenig <[email protected]>

* bump to ign-common 4.4

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@chapulina chapulina Awaiting requested review from chapulina

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @mjcarroll