Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum values in ViewAngle widget #1221

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

chapulina
Copy link
Contributor

Summary

Use the absolute maximum number for the widget. I'm dealing with some really large worlds and the current limits aren't enough:

Screenshot from 2021-11-24 15-19-00

Test it

Load the widget and input crazily large numbers.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Nov 24, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #1221 (b4f87e8) into ign-gazebo6 (96ed1ef) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1221      +/-   ##
===============================================
- Coverage        61.92%   61.92%   -0.01%     
===============================================
  Files              275      275              
  Lines            22457    22457              
===============================================
- Hits             13907    13906       -1     
- Misses            8550     8551       +1     
Impacted Files Coverage Δ
src/Server.cc 86.14% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ed1ef...b4f87e8. Read the comment docs.

@chapulina chapulina merged commit 525572f into ign-gazebo6 Nov 29, 2021
@chapulina chapulina deleted the chapulina/6/max_vals branch November 29, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants