Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualize lidar #1224

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Fix visualize lidar #1224

merged 1 commit into from
Dec 2, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 1, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

This may fix #1202

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde self-assigned this Dec 1, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1224 (5746cc9) into ign-gazebo4 (5168544) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 5746cc9 differs from pull request most recent head 6316c21. Consider uploading reports for the commit 6316c21 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4    #1224      +/-   ##
===============================================
- Coverage        66.41%   66.37%   -0.04%     
===============================================
  Files              250      250              
  Lines            19256    19256              
===============================================
- Hits             12788    12782       -6     
- Misses            6468     6474       +6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 93.04% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5168544...6316c21. Read the comment docs.

@chapulina chapulina merged commit c473a08 into ign-gazebo4 Dec 2, 2021
@chapulina chapulina deleted the ahcorde/fix/visualizeLidar branch December 2, 2021 06:43
@ahcorde ahcorde mentioned this pull request Dec 2, 2021
19 tasks
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants