Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] 👩‍🌾 Make depth camera tests more robust (#897) #1257

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

chapulina
Copy link
Contributor

⬅️ Backport

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #1257 (9fbb0f3) into ign-gazebo3 (fe07887) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1257      +/-   ##
===============================================
- Coverage        77.26%   77.25%   -0.01%     
===============================================
  Files              227      227              
  Lines            13511    13511              
===============================================
- Hits             10439    10438       -1     
- Misses            3072     3073       +1     
Impacted Files Coverage Δ
src/Server.cc 84.33% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe07887...9fbb0f3. Read the comment docs.

Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chapulina chapulina merged commit 41d4aba into ign-gazebo3 Dec 21, 2021
@chapulina chapulina deleted the chapulina/3/backport/897 branch December 21, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants