Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable more tests on Windows #1286

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Disable more tests on Windows #1286

merged 4 commits into from
Jan 13, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

This addresses tests that are new on Fortress.

The goal is to have zero failing tests on Windows, this way we know if we're introducing new failures.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 12, 2022
@chapulina chapulina added the tests Broken or missing tests / testing infra label Jan 12, 2022
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blast545
Copy link
Contributor

Although CI result has still some failing tests, did you take as the list of tests to disable the one I had in the original issue? or did you removed the last ones from CI? @chapulina

@chapulina
Copy link
Contributor Author

Although CI result has still some failing tests, did you take as the list of tests to disable the one I had in the original issue? or did you removed the last ones from CI?

I was tackling the ones I saw failing on #1277, let me do the rest now

@chapulina chapulina mentioned this pull request Jan 12, 2022
7 tasks
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Ok, I tackled other recent tests in 6ace1df.

I think we should wait for an ign-common release (gazebosim/gz-common#288), which I hope will make the ElementUpdateFixture.WorldWithModelsIncludedWithInvalidUris test pass on all platforms.

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1286 (a44d9cd) into ign-gazebo6 (db38ea9) will increase coverage by 0.02%.
The diff coverage is 66.38%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1286      +/-   ##
===============================================
+ Coverage        62.21%   62.24%   +0.02%     
===============================================
  Files              276      278       +2     
  Lines            23016    23135     +119     
===============================================
+ Hits             14320    14400      +80     
- Misses            8696     8735      +39     
Impacted Files Coverage Δ
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
src/systems/physics/Physics.cc 71.55% <ø> (ø)
src/Conversions.cc 82.55% <13.33%> (-1.15%) ⬇️
src/systems/navsat/NavSat.cc 69.04% <69.04%> (ø)
src/Link.cc 94.16% <92.30%> (+0.61%) ⬆️
include/ignition/gazebo/components/NavSat.hh 100.00% <100.00%> (ø)
src/SdfEntityCreator.cc 85.33% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6ef9b...a44d9cd. Read the comment docs.

@chapulina chapulina merged commit 2afd96d into ign-gazebo6 Jan 13, 2022
@chapulina chapulina deleted the chapulina/6/win_tests branch January 13, 2022 22:31
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

@iche033 iche033 mentioned this pull request Feb 2, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress needs upstream release Blocked by a release of an upstream library tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants