Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add surface to buoyancy engine. (retarget fortress) #1298

Merged
merged 7 commits into from
Jan 19, 2022
Merged

Add surface to buoyancy engine. (retarget fortress) #1298

merged 7 commits into from
Jan 19, 2022

Commits on Jan 18, 2022

  1. Add unit test for surface 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    ef7f044 View commit details
    Browse the repository at this point in the history

  2. update example 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    6d3285b View commit details
    Browse the repository at this point in the history

  3. codecheck 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    f60df42 View commit details
    Browse the repository at this point in the history

  4. Add surface to buoyancy engine. 

    The buoyancy engine should stop working when it crosses the water surface. This PR adds a `<surface>` tag which stops the buoyancy engine from exerting an upward force when the vehicle is surfacing.

Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    3cafdc2 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. update according to feedback 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    e3eb14f View commit details
    Browse the repository at this point in the history

  2. add param 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    50a3979 View commit details
    Browse the repository at this point in the history

  3. more tweaks 

    Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    b30cdcf View commit details
    Browse the repository at this point in the history