Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Link::SetLinearVelocity() method #1323

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Feb 7, 2022

๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ

๐ŸŽ‰ New feature

Summary

This PR adds a Link::SetLinearVelocity() method. I foresee this method being useful for testing behaviour of systems like the hydrodynamics or liftDrag plugin which are dependent on velocity for their output forces.

Signed-off-by: Arjo Chakravarty [email protected]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This PR adds a `Link::SetLinearVelocity()` method. I forsee this method being useful for testing behaviour of systems like the hydrodynamics or liftDrag plugin which are dependent on velocity for their output forces.

Signed-off-by: Arjo Chakravarty <[email protected]>
@github-actions github-actions bot added the ๐Ÿฏ fortress Ignition Fortress label Feb 7, 2022
@arjo129 arjo129 self-assigned this Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1323 (28e212c) into ign-gazebo6 (eeb80cd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

โ— Current head 28e212c differs from pull request most recent head 6ab486f. Consider uploading reports for the commit 6ab486f to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1323      +/-   ##
===============================================
+ Coverage        62.05%   62.07%   +0.01%     
===============================================
  Files              278      278              
  Lines            23370    23323      -47     
===============================================
- Hits             14502    14477      -25     
+ Misses            8868     8846      -22     
Impacted Files Coverage ฮ”
include/ignition/gazebo/Link.hh 100.00% <รธ> (รธ)
src/Link.cc 94.48% <100.00%> (+0.32%) โฌ†๏ธ
src/systems/buoyancy/Buoyancy.cc 82.60% <0.00%> (+0.08%) โฌ†๏ธ
src/systems/magnetometer/Magnetometer.cc 70.88% <0.00%> (+0.77%) โฌ†๏ธ
src/systems/imu/Imu.cc 72.61% <0.00%> (+0.87%) โฌ†๏ธ
src/systems/air_pressure/AirPressure.cc 73.23% <0.00%> (+1.08%) โฌ†๏ธ
src/systems/altimeter/Altimeter.cc 73.97% <0.00%> (+1.13%) โฌ†๏ธ
src/systems/logical_camera/LogicalCamera.cc 75.64% <0.00%> (+1.22%) โฌ†๏ธ
src/systems/thruster/Thruster.cc 92.07% <0.00%> (+1.81%) โฌ†๏ธ
...int_position_controller/JointPositionController.cc 74.04% <0.00%> (+2.19%) โฌ†๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update eeb80cd...6ab486f. Read the comment docs.

include/ignition/gazebo/Link.hh Outdated Show resolved Hide resolved
include/ignition/gazebo/Link.hh Outdated Show resolved Hide resolved
@arjo129 arjo129 merged commit 83f2f74 into ign-gazebo6 Feb 8, 2022
@arjo129 arjo129 deleted the arjo/feat/set_link_velocity branch February 8, 2022 02:27
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿฏ fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants