Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables Failing Buoyancy Tests on Win32 #1368

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Feb 28, 2022

🦟 Bug fix

See #1307 (comment)

Summary

Buoyancy tests failing on windows. Disabling them to prevent noise.

Signed-off-by: Arjo Chakravarty [email protected]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

See #1307 (comment)

Buoyancy tests failing on windows. Disabling them to prevent noise.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from azeey February 28, 2022 01:43
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #1368 (5f3faba) into ign-gazebo6 (e0d88f7) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 5f3faba differs from pull request most recent head f15fe1e. Consider uploading reports for the commit f15fe1e to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1368      +/-   ##
===============================================
+ Coverage        62.91%   62.98%   +0.07%     
===============================================
  Files              299      301       +2     
  Lines            24151    24199      +48     
===============================================
+ Hits             15194    15242      +48     
  Misses            8957     8957              
Impacted Files Coverage Δ
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
src/systems/physics/Physics.cc 71.55% <ø> (ø)
src/systems/pose_publisher/PosePublisher.hh 100.00% <ø> (ø)
src/Link.cc 94.77% <100.00%> (+0.28%) ⬆️
src/SimulationRunner.cc 92.07% <100.00%> (-0.31%) ⬇️
src/SystemInternal.hh 100.00% <100.00%> (ø)
src/SystemManager.cc 100.00% <100.00%> (ø)
src/systems/lift_drag/LiftDrag.cc 62.85% <100.00%> (ø)
src/systems/pose_publisher/PosePublisher.cc 94.71% <100.00%> (+0.21%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d17cc1...f15fe1e. Read the comment docs.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arjo129 arjo129 enabled auto-merge (squash) March 1, 2022 00:22
@arjo129 arjo129 merged commit b04aaed into ign-gazebo6 Mar 1, 2022
@arjo129 arjo129 deleted the arjo/fix/disable_buyoyancy_on_win32 branch March 1, 2022 02:18
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants