Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up various warnings caught by clang12 #1421

Merged
merged 5 commits into from
Apr 1, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

Signed-off-by: Michael Carroll [email protected]

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 1, 2022
@mjcarroll mjcarroll self-assigned this Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1421 (33a4c9e) into main (f6ba375) will increase coverage by 0.00%.
The diff coverage is 14.81%.

@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   62.34%   62.34%           
=======================================
  Files         317      317           
  Lines       24419    24417    -2     
=======================================
- Hits        15224    15223    -1     
+ Misses       9195     9194    -1     
Impacted Files Coverage Δ
.../gui/plugins/transform_control/TransformControl.cc 7.36% <ø> (+0.01%) ⬆️
...lization_capabilities/VisualizationCapabilities.cc 3.66% <0.00%> (ø)
src/rendering/RenderUtil.cc 36.94% <0.00%> (ø)
src/systems/contact/Contact.hh 100.00% <ø> (ø)
src/systems/particle_emitter/ParticleEmitter.cc 55.40% <0.00%> (ø)
src/systems/scene_broadcaster/SceneBroadcaster.hh 100.00% <ø> (ø)
src/systems/thruster/Thruster.cc 92.30% <ø> (-0.06%) ⬇️
...ems/collada_world_exporter/ColladaWorldExporter.hh 100.00% <100.00%> (ø)
...ems/kinetic_energy_monitor/KineticEnergyMonitor.hh 100.00% <100.00%> (ø)
src/systems/user_commands/UserCommands.hh 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ba375...33a4c9e. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! They will all come back though unless we setup some CI for this.

@chapulina chapulina merged commit 8c690ff into main Apr 1, 2022
@chapulina chapulina deleted the clang12_cleanups branch April 1, 2022 17:54
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants