Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated common::SubMesh::MaterialIndex() with GetMaterialIndex() #1436

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

adlarkin
Copy link
Contributor

Signed-off-by: Ashton Larkin [email protected]

🦟 Bug fix

Summary

This PR replaces deprecated calls to ignition::common::SubMesh::MaterialIndex() with the new GetMaterialIndex() method that was introduced in gazebosim/gz-common#319.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe it makes sense to adapt addSubmeshFunc to use std::optional

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1436 (e21a185) into main (a5464eb) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   62.37%   62.37%   -0.01%     
==========================================
  Files         317      317              
  Lines       24489    24493       +4     
==========================================
+ Hits        15276    15278       +2     
- Misses       9213     9215       +2     
Impacted Files Coverage Δ
...ems/collada_world_exporter/ColladaWorldExporter.cc 93.52% <66.66%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5464eb...e21a185. Read the comment docs.

@adlarkin adlarkin merged commit f9f2bbd into main Apr 11, 2022
@adlarkin adlarkin deleted the adlarkin/remove_deprecated_common_submeshIdx branch April 11, 2022 19:35
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants