Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in garden : ign-utils2, ign-plugin2 #1444

Merged
merged 10 commits into from
Apr 15, 2022

Conversation

methylDragon
Copy link
Contributor

Signed-off-by: methylDragon <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 13, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

examples/worlds/multi_lrauv_race.sdf Outdated Show resolved Hide resolved
src/gui/plugins/spawn/Spawn.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1444 (2117f1c) into main (c660c87) will increase coverage by 0.37%.
The diff coverage is n/a.

❗ Current head 2117f1c differs from pull request most recent head ec60a6b. Consider uploading reports for the commit ec60a6b to get more accurate results

@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
+ Coverage   35.01%   35.39%   +0.37%     
==========================================
  Files          44       43       -1     
  Lines        2356     2331      -25     
==========================================
  Hits          825      825              
+ Misses       1531     1506      -25     
Impacted Files Coverage Δ
...ins/component_inspector/moc_ComponentInspector.cpp 9.21% <0.00%> (-0.07%) ⬇️
src/gui/plugins/spawn/qrc_Spawn.cpp 100.00% <0.00%> (ø)
...c/gui/plugins/scene_manager/qrc_GzSceneManager.cpp 100.00% <0.00%> (ø)
...gui/plugins/select_entities/qrc_SelectEntities.cpp 100.00% <0.00%> (ø)
...ins/component_inspector/qrc_ComponentInspector.cpp 100.00% <0.00%> (ø)
...ntity_context_menu/qrc_EntityContextMenuPlugin.cpp 100.00% <0.00%> (ø)
...ion_capabilities/qrc_VisualizationCapabilities.cpp 100.00% <0.00%> (ø)
src/gui/plugins/component_inspector/moc_Pose3d.cpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c660c87...ec60a6b. Read the comment docs.

methylDragon and others added 3 commits April 12, 2022 18:58
chapulina and others added 3 commits April 14, 2022 11:55
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
methylDragon and others added 3 commits April 14, 2022 21:18
Signed-off-by: Louise Poubel <[email protected]>
…thub.com/ignitionrobotics/ign-gazebo into ci_matching_branch/bump_garden_ign-gazebo7

Signed-off-by: Louise Poubel <[email protected]>
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please

@chapulina
Copy link
Contributor

chapulina commented Apr 15, 2022

  • ✅ GitHub actions Focal only has known test failures
  • ✅ Windows has 3 test failures, not sure if they're new, but we don't need to block on them
  • ⌛ Homebrew is compiling Gazebo
  • ✅ Jenkins Ubuntu has new warnings related to missing benchmark dependency - no need to block on this

@chapulina
Copy link
Contributor

Ouch homebrew was so close 😢

Error: Could not symlink lib/python/sdformat.cpython-39-darwin.so
Target /usr/local/lib/python/sdformat.cpython-39-darwin.so
is a symlink belonging to sdformat13. You can unlink it:
  brew unlink sdformat13

To force the link and overwrite all conflicting files:
  brew link --overwrite ignition-gazebo7

To list all files that would be deleted:
  brew link --overwrite --dry-run ignition-gazebo7

I believe this is not this PR's fault, but a new conflict introduced by the new SDF python bindings. CC @ahcorde

I'm not going to block this PR on this because Garden has been broken long enough and macOS is not an officially supported platform. We'll come back to fix it promptly.

@chapulina chapulina merged commit 666a846 into main Apr 15, 2022
@chapulina chapulina deleted the ci_matching_branch/bump_garden_ign-gazebo7 branch April 15, 2022 17:32
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants