Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead ign.cc file #1474

Merged
merged 2 commits into from
May 5, 2022
Merged

Remove dead ign.cc file #1474

merged 2 commits into from
May 5, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

I don't know how we ended up with 2 ign.cc files:

The file was moved from src/cmd to src in ebfc66, which dates back to Blueprint. Citadel only has the one in src, but from Dome we have both files 🤔

Maybe another PR was targeting src/cmd.ign.cc in parallel and ended up recreating the file? 🤷🏽‍♀️

I believe the one under cmd isn't being compiled, so I'm removing it in this PR. I compared it to the one in cmd and it looks like it doesn't have any extra features that should be ported to the remaining one.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the bug Something isn't working label May 4, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1474 (3e7c7b5) into ign-gazebo6 (269c9b9) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo6    #1474   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 212aaed...3e7c7b5. Read the comment docs.

Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧟

@chapulina chapulina merged commit 270da60 into ign-gazebo6 May 5, 2022
@chapulina chapulina deleted the chapulina/6/rm_ign branch May 5, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants