Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial Fuel URL fix in example #1479

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

mabelzhang
Copy link
Contributor

🦟 Bug fix

I broke my Gazebo Fuel accounts. The authorities fixed the mess for me. But that means I’ve consolidated my accounts, and there’s an URL change to model files under my account. Thankfully it only affects one SDF file that only exists from ign-gazebo6 onwards.

Sorry to anyone using it. My fault for not knowing how to Internet.

Summary

Just make sure the models show up:

ign gazebo src/ign-gazebo/examples/worlds/multi_lrauv_race.sdf 

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <[email protected]>
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1479 (239702b) into ign-gazebo6 (52d12f1) will not change coverage.
The diff coverage is n/a.

❗ Current head 239702b differs from pull request most recent head b054d59. Consider uploading reports for the commit b054d59 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1479   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e0b21...b054d59. Read the comment docs.

@chapulina chapulina merged commit 06381ea into ign-gazebo6 May 12, 2022
@chapulina chapulina deleted the mabelzhang/fix_fuel_url branch May 12, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants