Check RGBD camera sensor connection #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
chapulina
approved these changes
Jun 2, 2022
mjcarroll
approved these changes
Jun 2, 2022
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1513 +/- ##
===============================================
- Coverage 33.58% 33.42% -0.17%
===============================================
Files 44 45 +1
Lines 2260 2271 +11
===============================================
Hits 759 759
- Misses 1501 1512 +11
Continue to review full report at Codecov.
|
chapulina
added a commit
that referenced
this pull request
Jun 8, 2022
* Check RGBD camera sensor connection (#1513) Signed-off-by: Ian Chen <[email protected]> * Fix regression with camera sensors not using the background color set in `<scene>` (#1515) Signed-off-by: Addisu Z. Taddese <[email protected]> * Rename ignition to gz in #1519. Signed-off-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Summary
Follow up to pull request #1480. RGBD camera was missing from the list of sensors. We added a warning to catch sensors missing from the list but unfortunately it didn't catch this because the RGBD camera was cast to a
CameraSensorand the incorrectHasConnectioncall was invoked. This should not happen once the todo note is addressed in Garden.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.