Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pose multiplication instead of subtraction #1521

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jun 6, 2022

🎉 New feature

Part of gz-math#60.

Summary

As noted in gz-math#60, there are concerns about the pose subtraction operator. Given that it is equivalent to multiplying by an inverse (albeit with reversed order), the subtraction operator will be deprecated. This PR replaces usage of the soon-to-be-deprecated operator with the equivalent multiplication by inverse.

Test it

Build against gazebosim/gz-math#438 and confirm that tests still pass and that there are no deprecation warnings.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of gz-math#60.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from chapulina as a code owner June 6, 2022 22:43
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1521 (553d630) into main (3d0867f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   63.62%   63.62%           
=======================================
  Files         330      330           
  Lines       25784    25784           
=======================================
  Hits        16406    16406           
  Misses       9378     9378           
Impacted Files Coverage Δ
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/gui/GuiSystem.hh 0.00% <ø> (ø)
include/gz/sim/rendering/SceneManager.hh 100.00% <ø> (ø)
src/Server.cc 89.72% <ø> (ø)
src/Util.cc 92.53% <ø> (ø)
src/gui/plugins/modules/EntityContextMenu.cc 19.78% <ø> (ø)
src/gui/plugins/spawn/Spawn.cc 10.27% <ø> (ø)
.../gui/plugins/transform_control/TransformControl.cc 7.37% <ø> (ø)
...lization_capabilities/VisualizationCapabilities.cc 3.69% <ø> (ø)
src/rendering/MarkerManager.cc 13.02% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e0c49...553d630. Read the comment docs.

@scpeters scpeters merged commit 09fd519 into main Jun 8, 2022
@scpeters scpeters deleted the scpeters/pose_deprecate_subtraction branch June 8, 2022 06:47
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants