Common widget GzColor replacement #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
AzulRadio
changed the title
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1530 +/- ##
===============================================
+ Coverage 64.40% 64.50% +0.09%
===============================================
Files 320 320
Lines 25892 25861 -31
===============================================
+ Hits 16677 16682 +5
+ Misses 9215 9179 -36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
chapulina
added
the
needs upstream release
AzulRadio
removed
the
needs upstream release
Signed-off-by: youhy <[email protected]>
jennuine
added
the
needs upstream release
|
This PR needs a release from |
chapulina
removed
the
needs upstream release
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
jennuine
approved these changes
Aug 11, 2022
jennuine
reviewed
Aug 11, 2022
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature
Summary
Replace implementation for lights (
Lights.qml) and material color (Material.qml) in Component Inspector with GzColor introduced in gz-gui#411For future maintainers: selecting color with the Material panel has a bug where the color of the material doesn't change when a color is selected. This bug is not introduced by this common widget.
Test it
Draft because of a possible bug in the Gazebo which causes the colors of the lights and material color can only be changed once.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.