Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the ability to stop a server #1551

Merged
merged 4 commits into from
Jun 24, 2022
Merged

Expose the ability to stop a server #1551

merged 4 commits into from
Jun 24, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 24, 2022

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

Exposes ServerPrivate::Stop through a new Server::Stop function. This is useful when using Gazebo as a library.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested a review from chapulina as a code owner June 24, 2022 15:43
src/Server_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Nate Koenig <[email protected]>
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1551 (38ab456) into ign-gazebo6 (6739800) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           ign-gazebo6    #1551   +/-   ##
============================================
  Coverage        64.00%   64.01%           
============================================
  Files              317      317           
  Lines            25632    25635    +3     
============================================
+ Hits             16407    16410    +3     
  Misses            9225     9225           
Impacted Files Coverage Δ
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
src/Server.cc 89.93% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6739800...38ab456. Read the comment docs.

src/Server_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI comes back happy

@chapulina chapulina added the 🏯 fortress Ignition Fortress label Jun 24, 2022
@chapulina chapulina mentioned this pull request Jun 24, 2022
7 tasks
@chapulina chapulina merged commit 5fc968d into ign-gazebo6 Jun 24, 2022
@chapulina chapulina deleted the stop-server branch June 24, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants