Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoogleTest to latest version #1559

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Update GoogleTest to latest version #1559

merged 5 commits into from
Jun 28, 2022

Conversation

mjcarroll
Copy link
Contributor

Import latest version of GoogleTest from upstream and adjust build accordingly.

Tracking issue: #1537

Signed-off-by: Michael Carroll [email protected]

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1559 (1af89a8) into main (b559eb6) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
+ Coverage   63.59%   63.61%   +0.02%     
==========================================
  Files         330      330              
  Lines       25881    25881              
==========================================
+ Hits        16459    16465       +6     
+ Misses       9422     9416       -6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 92.46% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b559eb6...1af89a8. Read the comment docs.

@chapulina chapulina added tests Broken or missing tests / testing infra 🌱 garden Ignition Garden labels Jun 28, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is unhappy, flaky ?

@mjcarroll
Copy link
Contributor Author

CI is unhappy, flaky ?

Those three aren't marked as required, I'm assuming they have existing problems here.

@mjcarroll mjcarroll merged commit 12e975a into main Jun 28, 2022
@mjcarroll mjcarroll deleted the bump_gtest branch June 28, 2022 23:43
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants