Refactor: Utilizes function to load animations #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahcorde, |
ahcorde
requested changes
Jun 30, 2022
ahcorde
requested changes
Jun 30, 2022
There was a problem hiding this comment.
linters are also failing
/github/workspace/src/rendering/SceneManager.cc:2311: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/rendering/SceneManager.cc:2312: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
/github/workspace/src/rendering/SceneManager.cc:2315: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/rendering/SceneManager.cc:2346: Should have a space between // and comment [whitespace/comments] [4]
/github/workspace/src/rendering/SceneManager.cc:2352: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/rendering/SceneManager.cc:2352: Should have a space between // and comment [whitespace/comments] [4]
onurtore
force-pushed
the
otore19/ApplyAnimation
branch
from
5ff4bc0
to
803d46e
Compare
Signed-off-by: Onur Berk Tore <[email protected]>
onurtore
force-pushed
the
otore19/ApplyAnimation
branch
from
803d46e
to
127217d
Compare
ahcorde
requested changes
Jun 30, 2022
Signed-off-by: Onur Berk Tore <[email protected]>
ahcorde
approved these changes
Jun 30, 2022
ahcorde
requested changes
Jun 30, 2022
There was a problem hiding this comment.
/github/workspace/include/ignition/gazebo/rendering/SceneManager.hh:206: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
/github/workspace/include/ignition/gazebo/rendering/SceneManager.hh:206: Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
/github/workspace/src/rendering/SceneManager.cc:2284: Lines should be <= 80 characters long [whitespace/line_length] [2]
Long lines with more than 80 charecters fixes. Extra spaces are removed. underored_map included Signed-off-by: Onur Berk Tore <[email protected]>
Signed-off-by: Onur Berk Tore <[email protected]>
ahcorde
requested changes
Jun 30, 2022
There was a problem hiding this comment.
it's not compiling, see the comment
https:/gazebosim/gz-sim/runs/7139388778?check_suite_focus=true
ahcorde
requested changes
Jul 1, 2022
Fixes compilation error by returning empty mapAnimNameId. Signed-off-by: Onur Berk Tore <[email protected]>
Fixed the compilation error, did not see any other problems in the Build. Am i missing somewhere? |
onurtore
changed the title
Signed-off-by: Onur Berk Tore <[email protected]>
ahcorde
requested changes
Jul 4, 2022
added 3 commits
July 4, 2022 17:24
Signed-off-by: Onur Berk Tore <[email protected]>
Signed-off-by: Onur Berk Tore <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1568 +/- ##
============================================
Coverage 64.01% 64.02%
============================================
Files 317 317
Lines 25638 25649 +11
============================================
+ Hits 16413 16422 +9
- Misses 9225 9227 +2
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Jul 4, 2022
liamhan0905
pushed a commit
that referenced
this pull request
Jul 25, 2022
Signed-off-by: Onur Berk Tore <[email protected]> Signed-off-by: Liam Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizes new LoadAnimations function to load animations trajectories during actor creation.
Part of three PR for the #1564 (comment) for slimming down the CreateActor function.