Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vector3 with common widget vector3 #1569

Merged
merged 7 commits into from
Jul 20, 2022

Conversation

AzulRadio
Copy link
Contributor

@AzulRadio AzulRadio commented Jun 30, 2022

Signed-off-by: youhy [email protected]

New feature

Summary

Implement Gravity and Magnetic Field in Component Inspector with common widget GzVector3 introduced in gz-gui#427

Behavior should be exactly the same as before.

image

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@AzulRadio AzulRadio changed the title implement vector3 with common widget vector3 Implement vector3 with common widget vector3 Jul 1, 2022
@AzulRadio AzulRadio changed the base branch from ign-gazebo6 to ign-gazebo3 July 1, 2022 15:13
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ign-gazebo3@4585958). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a9881b9 differs from pull request most recent head dd3c1d9. Consider uploading reports for the commit dd3c1d9 to get more accurate results

@@              Coverage Diff               @@
##             ign-gazebo3    #1569   +/-   ##
==============================================
  Coverage               ?   77.82%           
==============================================
  Files                  ?      250           
  Lines                  ?    14465           
  Branches               ?        0           
==============================================
  Hits                   ?    11257           
  Misses                 ?     3208           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4585958...dd3c1d9. Read the comment docs.

@chapulina chapulina requested a review from jennuine July 1, 2022 22:39
@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) 🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience labels Jul 1, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jul 1, 2022
@jennuine jennuine mentioned this pull request Jul 13, 2022
5 tasks
@jennuine jennuine removed the needs upstream release Blocked by a release of an upstream library label Jul 14, 2022
src/gui/plugins/component_inspector/Vector3d.qml Outdated Show resolved Hide resolved
src/gui/plugins/component_inspector/Vector3d.qml Outdated Show resolved Hide resolved
@AzulRadio AzulRadio marked this pull request as ready for review July 19, 2022 22:12
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 3ee889b into ign-gazebo3 Jul 20, 2022
@chapulina chapulina deleted the azulradio/common_widget_vector branch July 20, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants