Fix component updates

[jennuine]

🦟 Bug fix

Fixes #1022

Summary

To speed up performance, removed components were cached/stored here:

gz-sim/include/ignition/gazebo/detail/View.hh

Lines 140 to 149 in 1f6c126

	/// The reason for moving entities with missing components to invalidData
	/// instead of completely deleting them from the view is because if components
	/// are added back later and the entity needs to be re-added to the view,
	/// tuple creation can be costly. So, this approach is used instead to
	/// maintain runtime performance (the tradeoff of mainting performance is
	/// increased complexity and memory usage).
	///
	/// \sa missingCompTracker
	private: std::unordered_map<Entity, ComponentData> invalidData;
	private: std::unordered_map<Entity, ConstComponentData> invalidConstData;

Then when the same component was re-added:

gz-sim/src/EntityComponentManager.cc

Lines 1088 to 1089 in 1f6c126

	viewPair.second.first->NotifyComponentAddition(_entity,
	this->IsNewEntity(_entity), _componentTypeId);

The component data was moved from invalidData to validData but the data was never updated.

The fix is to check that component needs updated in the EntityComponentManager::SetState functions then retrieve the component and deserialize the data again (to update the re-added component).

---

To run unit tests:

./path/to/build/UNIT_EntityComponentManager_TEST --gtest_filter="*AddRemoveAddComponents*"

---

To test through the GUI:

ign gazebo -v 4 lights.sdf

Before PR

After PR

Thanks @chapulina for the help!

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #1580 (bb7f37e) into ign-gazebo6 (d6e69d0) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           ign-gazebo6    #1580      +/-   ##
===============================================
+ Coverage        64.02%   64.14%   +0.12%     
===============================================
  Files              317      317              
  Lines            25649    25667      +18     
===============================================
+ Hits             16422    16465      +43     
+ Misses            9227     9202      -25     

Impacted Files	Coverage Δ
src/EntityComponentManager.cc	89.35% <100.00%> (-0.01%)	⬇️
src/Util.cc	92.53% <100.00%> (ø)
src/systems/user_commands/UserCommands.cc	57.67% <100.00%> (+4.34%)	⬆️
src/SimulationRunner.cc	90.93% <0.00%> (-0.96%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39bc25...bb7f37e. Read the comment docs.

[ahcorde]

I can confirm that this is working like a charm! Thank you!

I had a minor comment about the error message