Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Inspector with common widget pose plotting #1607

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy [email protected]

New feature

As mentioned here #1571. This PR implements the component inspector's pose with the common widget pose that has the plotting feature. Then we can forward-port gz-sim citadel (3) to fortress (6) without a recession of features.

This PR should be merged after both gazebosim/gz-gui#439 and the forward porting for #1571 from citadel to fortress are merged.

Summary

See GIF in gazebosim/gz-gui#439

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@AzulRadio AzulRadio added GUI Gazebo's graphical interface (not pure Ignition GUI) needs upstream release Blocked by a release of an upstream library OOBE 📦✨ Out-of-box experience labels Jul 21, 2022
@chapulina chapulina requested a review from jennuine July 22, 2022 20:55
@chapulina chapulina added the 🏯 fortress Ignition Fortress label Jul 25, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1607 (5d2ab17) into ign-gazebo6 (8c9489d) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-gazebo6    #1607      +/-   ##
===============================================
+ Coverage        64.40%   64.43%   +0.02%     
===============================================
  Files              320      320              
  Lines            25892    25892              
===============================================
+ Hits             16677    16683       +6     
+ Misses            9215     9209       -6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 91.89% <0.00%> (+0.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jenn Nguyen <[email protected]>
@AzulRadio AzulRadio marked this pull request as ready for review August 7, 2022 18:08
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve once a new gz-gui6 has been released. Left some minor comments

src/gui/plugins/component_inspector/Pose3d.qml Outdated Show resolved Hide resolved
@chapulina chapulina mentioned this pull request Aug 10, 2022
7 tasks
@jennuine jennuine removed the needs upstream release Blocked by a release of an upstream library label Aug 12, 2022
@AzulRadio AzulRadio merged commit 4602312 into ign-gazebo6 Aug 12, 2022
@AzulRadio AzulRadio deleted the azulradio/common_widget_pose branch August 12, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI) OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants